Fix the tick update order bug

[Banned]

The order in which people have signed up should not affect whether or not they get to keep their roids.

The bug:

If planet A attacks planet B, landing pt 1000
and planet C attacks planet A, landing pt 1000
then planet C may steal roids planet A caps from planet B the same tick
depending on which order they tick in

This is obviously bad behavior. Things like this should be consistent (that is, behave the same regardless of which order people sign up in).

[Doorsdown]

roid counts shouldn't be updated till after it is determed how much is to be lost this way when it is taken out it won't matter

[Shyne]

Im sure this was never fixed because it was quite a lot of work to do.

Now PAN is being written from scratch we can hope it will be fixed.

[Doorsdown]

something like

$status = "combat";
while($status=="combat")
{
//set how much roids to be duducted from a planet
//set how many roids they gain
$status="end";
}

subtractRoids();
addRoids();

[Heartless]

Originally Posted by Doorsdown

something like

$status = "combat";
while($status=="combat")
{
//set how much roids to be duducted from a planet
//set how many roids they gain
$status="end";
}

subtractRoids();
addRoids();

It's not easy to hack stuff into a badly designed statemachine.

[Doorsdown]

no but that kind of order is needed to keep the bug from being possible even in the new code

[mist]

it shouldn't be that hard to dump roids gained in to a differet table tho, and then add the two tables together once all the combat is over. that'd seem to avoid the state machine problem?

[_Kila_]

IMO, the rocks you steal shouldn't be stolen if you are landed on on the same tick as the combat happens at the same time and your rocks come home after your ships have attacked the enemy roidbase thing which is the same time your roidbase thing gets attacked.

ie. I have 5000 roids, 1:1:1 attacks me and steals 1250 roids, and I attack 1:1:2 who has 2000 roids, when 1:1:1 comes to my roids, there will be 5000 because this is the same time I get to 1:1:2 and I haven't capped them there yet. This would mean they steal 1250 of my roids and beam them home, and after they are stolen my new 500 roids that I have stolen appear.

seems a bit confusing but its how it should be IMO.