Why won't it work :(

[Gayle29uk]

This is the relevant code from the form...

echo '<tr><td><INPUT TYPE=CHECKBOX NAME="sizefilter">
  Imbalanced score distribution.</td>
  <td><input type="text" name="scorecoeff" value="35" size=3>
  Coefficient of variation</td></tr>';
echo '<tr><td><INPUT TYPE=CHECKBOX NAME="roidfilter">
  Imbalanced roid distribution.</td>
  <td><input type="text" name="roidcoeff" value="40" size=3>
  Coefficient of variation</td></tr>';

Why when I check roidfilter is it always NULL? sizefilter works fine and this is driving me insane now

[Gayle29uk]

Now another one I just added doesn't work

Is there a limit on the number of values you can pass via a form or something that I don't know about?

[Jester]

I'd be quite surprised if there is a limit, I once filled out a form with 400 checkboxes. Do you have some more code I can look at?

Jester

[Gayle29uk]

Originally posted by Jester
Do you have some more code I can look at?

Jester

Eek...my code is ugly

2 secs while I grab some...

[Gayle29uk]

echo '<table align="center" border="1" cellspacing="0" cellpadding="2">
  <tr><th colspan=6>Top 10 galaxies by ratio.<br></th></tr>';
echo '<tr align="center"><th>X</th><th>Y</th><th>Galaxy</th>
  <th>Size</th><th>Score</th><th>Ratio</th></tr>';
$count=0;
while($count<$rows){
    if((($sizedev[$count]<$roidcoeff)||$roidfilter!="on")&&
(($scoredev[$count]<$scorecoeff)||$sizefilter!="on")){
        echo '<tr align="center"><td>'.$planets[$count][1].'</td>
        <td>'.$planets[$count][2].'</td><td>'.$planets[$count][5].'</td>
        <td>'.$planets[$count][6].'</td><td>'.$planets[$count][7].'</td>
        <td>'.$planets[$count][0].'</td></tr>';
    }
    $count++;
}
echo '</table>';

That table uses roidfilter (one of the problem variables). No matter what happens to the checkbox it's NULL.

The other variable is $maxresults and is set in the form by this line...

echo '<tr><td align="right">Maximum number of results</td>
  <td><input type="text" name="maxresults" value="25">
  </td></tr>';

It's used in this line...

$query='SELECT x,y,galaxy,score,size,ratio FROM galdump 
  WHERE age=0 AND score<'.$maxscore.' AND score>'.$minscore.' 
  AND size<'.$maxsize.' AND size>'.$minsize.' AND ratio<'.$maxratio.' 
  AND ratio>'.$minratio.'  order by size desc limit 0,'.$maxresults;

...and is always NULL as well. I have no idea whatsoever why

[Jester]

You could try setting a value. I seem to recall having some trouble with checkboxes that don't have a value defined. It's been about a year since I've done any php of my own though

Jester

[edit]This might help.[/edit]

[Gayle29uk]

Jester I love you \o/

It works now

[queball]

Your code isn't particularly ugly, but if you're concerned I find double quotes are cleaner for SQL:

$query="SELECT x,y,galaxy,score,size,ratio FROM galdump 
  WHERE age=0 AND score<$maxscore AND score>$minscore
  AND size<$maxsize AND size>$minsize AND ratio<$maxratio
  AND ratio>$minratio  order by size desc limit 0,$maxresults";

And heredocs for HTML:

        echo <<<END
        <tr align="center"><td>{$planets[$count][1]}</td>
        <td>{$planets[$count][2]}</td><td>{$planets[$count][5]}</td>
        <td>{$planets[$count][6]}</td><td>{$planets[$count][7]}</td>
        <td>{$planets[$count][0]}</td></tr>
END;

Also, I'd like to pimp this if you're gonna use arbitrary strings in SQL statements:
http://php.red-illusions.dk/forum/vi....php?p=358#358

[Gayle29uk]

Originally posted by queball
Also, I'd like to pimp this if you're gonna use arbitrary strings in SQL statements:
http://php.red-illusions.dk/forum/vi....php?p=358#358

I'll keep that in mind in case I ever decide to make this toy properly public. Need to add better input filtering if I do, as it stands anyone messing around with it gets what they deserve, an error

[Jester]

Originally posted by Gayle29uk
Jester I love you \o/

It works now

\o/

Unlike queball I don't prefer here docs for html. That said it's probably more readable, but I quite simply prefer writing strings of html.

However, doublequoting SELECT statements and single quoting inside is more 'correct' as double quotes in the SELECT statement is against the ANSI standard (and won't work in some other SQL systems). Of course variable interpolation doesn't hurt

Jester

[Wombat]

I didn't know you were Continental Jester, that was pure spanish :/

[Jester]

Originally posted by Wombat
I didn't know you were Continental Jester, that was pure spanish :/

Que?

Jester

[MAdnRisKy]

Originally posted by Jester
Que?

Jester

it's Quai?

(I think, at least it is if you're trying manuel over frog)

[Jester]

Originally posted by MAdnRisKy
it's Quai?

(I think, at least it is if you're trying manuel over frog)

I believe I proved I was not Spanish though

Jester

[queball]

"¿qué?" is the Spanish equivalent of posting "what?". que is just like the French meaning, see http://www.wordreference.com/es/en/t...n.asp?spen=que

The French would say quoi. (like in pourquoi). Un Quai is the French for a quay.

[MAdnRisKy]

well now see neither of us speak spanish :/

[Jester]

I don't think queball does either...

Jester

[Slidey]

and once again we've proved queys websearching skills

[inf]

knowledge.

[Mong]

Originally posted by Jester
You could try setting a value.

Bingo!